-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added gasnet documentation #6382
base: master
Are you sure you want to change the base?
Conversation
@ct-clmsn how does this integrate with the existing docs. Could you talk to @dimitraka about this? She can help with everything related to docs. |
@hkaiser this mirrors the LCI documentation, so it explains the compile arguments. Will contact @dimitraka for details! |
@ct-clmsn I suggest building the documentation. It's the only way of seeing how your docs look in html and check that everything is fine. Some minors that I see at the moment:
|
@dimitraka updated the files, hope these align correctly! |
@ct-clmsn Did you also build the documentation? To do so I suggest using the docker image and building hpx with |
@dimitraka thanks for verifying! |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
@dimitraka, @ct-clmsn is this good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Fixes: not applicable
Proposed Changes
Any background context you want to provide?
The GASNet PR didn't include the minimal documentation, this resolves that issue.